Draft
Conversation
Contributor
Author
|
rails/sprokets is using the concurrency library (so it'll be in any rails user's Gems already. But, it's using promises instead of a low level TPE https://github.com/rails/sprockets/search?q=export_concurrent might be some good inspiration for how this might work "properly" |
tomharvey
changed the title
Contributor
|
@tomharvey sorry for the delay on this! It's a great idea. I'll take a look as soon as I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... well that's overstating things a bit. This is a draft PR for a reason and for the discussion of #30
I can well imagine some philosophical objection to adding the concurrency gem, and if we want to go down this path there is some work on exception handling, testing and making the thread pool size configurable.
But, my deploy went from > 10min (got bored waiting) to < 1min.
If you're interested in seeing the performance change with your own use case, adding this to your Gemfile will do:
Currently, logging is broken - it logs when we start, but not complete the upload.